lkml.org 
[lkml]   [2017]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] NTB: ntb_tool: Add full multi-port NTB API support


On 30/11/17 02:37 PM, Serge Semin wrote:
> Changelog v2:
> - Remove driver Author/Description/License macros

This patch is already very long and should be split up, and you added
more to it? If you want to fix these macros it should be in it's own
patch with it's own justification.

> - u64 db_bits;
> char *buf, cmd;
> - ssize_t rc;
> + ssize_t ret;

I commented on this last time we saw these patches and changing the
variable name from 'rc' to 'ret' (in a number of places) is unnecessary
and just adds to the noise of an already gigantic patch. I'm personally
not going to review it further until I see a cleaner easier to read
patch or series.

Logan

\
 
 \ /
  Last update: 2017-11-30 23:25    [W:0.787 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site