Messages in this thread | | | Date | Thu, 30 Nov 2017 07:24:30 -0800 | From | Tony Lindgren <> | Subject | Re: [PATCH v3 4/4] DTS: Pandora: fix panel compatibility string |
| |
* H. Nikolaus Schaller <hns@goldelico.com> [171128 18:35]: > Hi, > > > Am 28.11.2017 um 17:18 schrieb Tony Lindgren <tony@atomide.com>: > > > > * H. Nikolaus Schaller <hns@goldelico.com> [171128 16:17]: > >> Hi Tony, > >> > >>> Am 28.11.2017 um 17:04 schrieb Tony Lindgren <tony@atomide.com>: > >>> > >>> * H. Nikolaus Schaller <hns@goldelico.com> [171128 15:52]: > >>>> We can remove the unnecessary "omapdss," prefix because > >>>> the omapdrm driver takes care of it when matching with > >>>> the driver table. > >>> > >>> So is this needed as a fix or is this another clean-up? > >>> > >>> So is this is really needed as a fix? > >> > >> Hm. How do you differentiate between "fix" and "cleanup"? > >> Maybe it is more a wording than a content issue... > >> > >> For me it is a "fix" because it is semantically wrong to have > >> a prefix where it is not needed. And "fixing" it changes the > >> compiler output by 8 bytes. > > > > How about let's call it a "typo fix" then? :) > > Well, it is not really a typo.
Well what if the stable people pick it into earlier stable series based on the word fix in the subject? That has happened before.
I suggest you update the dts patches to use wording like "update compatible to use new naming" or something similar.
Regards,
Tony
| |