Messages in this thread | | | Subject | Re: [PATCH v3 3/3] arm64: dts: meson-axg: add clock DT info for Meson AXG SoC | From | Yixun Lan <> | Date | Thu, 30 Nov 2017 14:01:32 +0800 |
| |
Hi Stephen
On 11/30/17 03:35, Stephen Boyd wrote: > On 11/28, Yixun Lan wrote: >> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi >> index b932a784b02a..36a2e98338a8 100644 >> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi >> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi >> @@ -7,6 +7,7 @@ >> #include <dt-bindings/gpio/gpio.h> >> #include <dt-bindings/interrupt-controller/irq.h> >> #include <dt-bindings/interrupt-controller/arm-gic.h> >> +#include <dt-bindings/clock/axg-clkc.h> >> >> / { >> compatible = "amlogic,meson-axg"; >> @@ -148,6 +149,20 @@ >> #address-cells = <0>; >> }; >> >> + hiubus: hiubus@ff63c000 { > > Maybe just call the node "bus@ff63c000"? > isn't this just a name? what's the benefits to change? personally, I tend to keep it this way, because it's better map to the data sheet
we also has 'aobus', 'cbus' scattered there..
>> + compatible = "simple-bus"; >> + reg = <0x0 0xff63c000 0x0 0x1c00>; >> + #address-cells = <2>; >> + #size-cells = <2>; >> + ranges = <0x0 0x0 0x0 0xff63c000 0x0 0x1c00>; >> + >> + clkc: clock-controller@0 { >> + compatible = "amlogic,axg-clkc"; >> + #clock-cells = <1>; >> + reg = <0x0 0x0 0x0 0x320>; >> + }; >> + }; >> + >> mailbox: mailbox@ff63dc00 { >> compatible = "amlogic,meson-gx-mhu", "amlogic,meson-gxbb-mhu"; >> reg = <0 0xff63dc00 0 0x400>; >> -- >> 2.15.0 >> >
| |