Messages in this thread | | | Subject | Re: [PATCH] block/aoe: discover_timer: Convert timers to use timer_setup() | From | Ed Cashin <> | Date | Fri, 3 Nov 2017 20:39:40 -0400 |
| |
On 11/02/2017 07:31 PM, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > This refactors the discover_timer to remove the needless locking and > state machine used for synchronizing timer death. Using del_timer_sync() > will already do the right thing.
Looks OK to me, thanks.
-- Ed
| |