lkml.org 
[lkml]   [2017]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] selftests/ftrace: Introduce exit_pass and exit_fail
On Wed, 1 Nov 2017 15:18:41 -0600
Shuah Khan <shuah@kernel.org> wrote:

> On 10/31/2017 10:23 PM, Masami Hiramatsu wrote:
> > On Tue, 31 Oct 2017 17:44:32 -0400
> > Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> >> On Tue, 31 Oct 2017 23:51:42 +0900
> >> Masami Hiramatsu <mhiramat@kernel.org> wrote:
> >>
> >>> diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/busy_check.tc b/tools/testing/selftests/ftrace/test.d/kprobe/busy_check.tc
> >>> index 74507db8bbc8..b8701fa0b8f2 100644
> >>> --- a/tools/testing/selftests/ftrace/test.d/kprobe/busy_check.tc
> >>> +++ b/tools/testing/selftests/ftrace/test.d/kprobe/busy_check.tc
> >>> @@ -8,7 +8,7 @@ echo > kprobe_events
> >>> echo p:myevent _do_fork > kprobe_events
> >>> test -d events/kprobes/myevent
> >>> echo 1 > events/kprobes/myevent/enable
> >>> -echo > kprobe_events && exit 1 # this must fail
> >>> +echo > kprobe_events && exit_fail
> >>
> >> Should we keep the comment about "this must fail", otherwise it may
> >> look like a mistake. Echoing in kprobe_events returns failure here?
> >
> > Ah, good catch! I misread the comment is for "exit 1"...
> >
> > Thank you,
> >
> >>
> >> -- Steve
> >>
> >>
> >>> echo 0 > events/kprobes/myevent/enable
> >>> echo > kprobe_events # this must succeed
> >>> clear_trace
> >
> >
>
> Hi Masami,
>
> Thanks Steve for the catch. I will wait for v2 then.

Sorry for later, I'll send it soon.

Thank you,

>
> thanks,
> -- Shuah
>


--
Masami Hiramatsu <mhiramat@kernel.org>

\
 
 \ /
  Last update: 2017-11-03 20:35    [W:3.023 / U:1.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site