Messages in this thread Patch in this message | | | From | "Niklas Söderlund" <> | Date | Fri, 3 Nov 2017 08:37:09 +0100 | Subject | Re: [PATCH] media: v4l: async: fix return of unitialized variable ret |
| |
Hi Colin,
Thanks for your patch.
On 2017-11-03 06:58:27 +0000, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > A shadow declaration of variable ret is being assigned a return error > status and this value is being lost when the error exit goto's jump > out of the local scope. This leads to an uninitalized error return value > in the outer scope being returned. Fix this by removing the inner scoped > declaration of variable ret. > > Detected by CoverityScan, CID#1460380 ("Uninitialized scalar variable") > > Fixes: fb45f436b818 ("media: v4l: async: Fix notifier complete callback error handling") > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> --- > drivers/media/v4l2-core/v4l2-async.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c > index 49f7eccc76db..7020b2e6d158 100644 > --- a/drivers/media/v4l2-core/v4l2-async.c > +++ b/drivers/media/v4l2-core/v4l2-async.c > @@ -550,7 +550,6 @@ int v4l2_async_register_subdev(struct v4l2_subdev *sd) > struct v4l2_device *v4l2_dev = > v4l2_async_notifier_find_v4l2_dev(notifier); > struct v4l2_async_subdev *asd; > - int ret; > > if (!v4l2_dev) > continue; > -- > 2.14.1 >
-- Regards, Niklas Söderlund
| |