lkml.org 
[lkml]   [2017]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: watchdog: f71808e_wdt: mark expected switch fall-throughs

Quoting Guenter Roeck <linux@roeck-us.net>:

> On Thu, Nov 02, 2017 at 02:28:17PM -0500, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>>
>> Notice that in this particular case I replaced "Fall" with a proper
>> "fall through" comment, which is what GCC is expecting to find.
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>

Thanks!

--
Gustavo A. R. Silva

>> ---
>> drivers/watchdog/f71808e_wdt.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/watchdog/f71808e_wdt.c b/drivers/watchdog/f71808e_wdt.c
>> index 8658dba..e0678c1 100644
>> --- a/drivers/watchdog/f71808e_wdt.c
>> +++ b/drivers/watchdog/f71808e_wdt.c
>> @@ -627,7 +627,7 @@ static long watchdog_ioctl(struct file *file,
>> unsigned int cmd,
>>
>> if (new_options & WDIOS_ENABLECARD)
>> return watchdog_start();
>> -
>> + /* fall through */
>>
>> case WDIOC_KEEPALIVE:
>> watchdog_keepalive();
>> @@ -641,7 +641,7 @@ static long watchdog_ioctl(struct file *file,
>> unsigned int cmd,
>> return -EINVAL;
>>
>> watchdog_keepalive();
>> - /* Fall */
>> + /* fall through */
>>
>> case WDIOC_GETTIMEOUT:
>> return put_user(watchdog.timeout, uarg.i);






\
 
 \ /
  Last update: 2017-11-03 15:48    [W:0.059 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site