Messages in this thread | | | From | Aleksandar Markovic <> | Subject | RE: [PATCH v7 2/5] irqchip/irq-goldfish-pic: Add Goldfish PIC driver | Date | Fri, 3 Nov 2017 14:10:13 +0000 |
| |
> From: Joe Perches [joe@perches.com] > ... >On Thu, 2017-11-02 at 17:21 +0100, Aleksandar Markovic wrote: > ... > > > Signed-off-by: Miodrag Dinic <miodrag.dinic@mips.com> > > Signed-off-by: Goran Ferenc <goran.ferenc@mips.com> > > Signed-off-by: Aleksandar Markovic <aleksandar.markovic@mips.com> > > wq > > vi much? >
:)
> > +/* > > + * Driver for MIPS Goldfish Programmable Interrupt Controller. > > + * > > + * Author: Miodrag Dinic <miodrag.dinic@mips.com> > > + * > > + * This program is free software; you can redistribute it and/or modify it > > + * under the terms of the GNU General Public License as published by the > > + * Free Software Foundation; either version 2 of the License, or (at your > > + * option) any later version. > > + */ > > Odd mix of spaces and tabs >
Will be fixed in v8.
> It'd be good to add a #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > before any #include so the pr_<level> output is prefixed appropriately.
Error and info messages will be completely revised in v8.
Thanks for the review!
Aleksandar
| |