lkml.org 
[lkml]   [2017]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v7 2/5] irqchip/irq-goldfish-pic: Add Goldfish PIC driver
Date
> From: Joe Perches [joe@perches.com]
> ...
>On Thu, 2017-11-02 at 17:21 +0100, Aleksandar Markovic wrote:
> ...
>
> > Signed-off-by: Miodrag Dinic <miodrag.dinic@mips.com>
> > Signed-off-by: Goran Ferenc <goran.ferenc@mips.com>
> > Signed-off-by: Aleksandar Markovic <aleksandar.markovic@mips.com>
> > wq
>
> vi much?
>

:)

> > +/*
> > + * Driver for MIPS Goldfish Programmable Interrupt Controller.
> > + *
> > + * Author: Miodrag Dinic <miodrag.dinic@mips.com>
> > + *
> > + * This program is free software; you can redistribute it and/or modify it
> > + * under the terms of the GNU General Public License as published by the
> > + * Free Software Foundation; either version 2 of the License, or (at your
> > + * option) any later version.
> > + */
>
> Odd mix of spaces and tabs
>

Will be fixed in v8.

> It'd be good to add a #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> before any #include so the pr_<level> output is prefixed appropriately.

Error and info messages will be completely revised in v8.

Thanks for the review!

Aleksandar

\
 
 \ /
  Last update: 2017-11-03 15:27    [W:0.071 / U:0.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site