lkml.org 
[lkml]   [2017]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL for 4.4 10/32] usb: gadget: configs: plug memory leak
    Date
    From: John Keeping <john@metanate.com>

    [ Upstream commit 38355b2a44776c25b0f2ad466e8c51bb805b3032 ]

    When binding a gadget to a device, "name" is stored in gi->udc_name, but
    this does not happen when unregistering and the string is leaked.

    Signed-off-by: John Keeping <john@metanate.com>
    Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    ---
    drivers/usb/gadget/configfs.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
    index 163d305e1200..6abb6a10ee82 100644
    --- a/drivers/usb/gadget/configfs.c
    +++ b/drivers/usb/gadget/configfs.c
    @@ -270,6 +270,7 @@ static ssize_t gadget_dev_desc_UDC_store(struct config_item *item,
    ret = unregister_gadget(gi);
    if (ret)
    goto err;
    + kfree(name);
    } else {
    if (gi->udc_name) {
    ret = -EBUSY;
    --
    2.11.0
    \
     
     \ /
      Last update: 2017-11-29 18:30    [W:3.559 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site