lkml.org 
[lkml]   [2017]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 04/11] trace-cmd: Extract parse_record_options() from trace_record()
From
Date
On Wed, 2017-11-29 at 09:53 -0500, Steven Rostedt wrote:
> On Tue, 28 Nov 2017 20:17:46 +0200
> Vladislav Valtchev <vladislav.valtchev@gmail.com> wrote:
>
> > On Tue, 2017-11-28 at 11:48 -0500, Steven Rostedt wrote:
> > >
> > > Is there a reason that init_instance() isn't called in
> > > init_common_record_context()?
> > >
> >
> > Hi Steven,
> >
> > init_instance() has been put into init_common_record_context() later,
> > in patch 8, "Making start,extract,stream,profile separate funcs".
>
> I have to ask. Why isn't it done in this patch. This patch appears to
> be the proper place to put it.
>

There is no reason, actually. You're absolutely right.
It's a leftover from several iterations of fixes (originally
'instance' was not part of ctx).

Therefore, I'll move that call to init_instance() inside init_common_record_context().


Vlad

\
 
 \ /
  Last update: 2017-11-29 16:18    [W:0.063 / U:0.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site