lkml.org 
[lkml]   [2017]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 2/3] pinctrl: mcp23s08: Use common error handling code in mcp23s08_dbg_show()
On Mon, Oct 30, 2017 at 4:47 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:

> + if (t)
> + goto report_failure;
>
> for (t = 0, mask = BIT(0); t < chip->ngpio; t++, mask <<= 1) {
> const char *label;
> @@ -758,8 +753,13 @@ static void mcp23s08_dbg_show(struct seq_file *s, struct gpio_chip *chip)
> /* NOTE: ignoring the irq-related registers */
> seq_puts(s, "\n");
> }
> -done:
> +unlock:
> mutex_unlock(&mcp->lock);
> + return;
> +
> +report_failure:
> + seq_puts(s, " I/O Error\n");
> + goto unlock;
> }

This is spaghetti coding. Not applied.
https://en.wikipedia.org/wiki/Spaghetti_code

Yours,
Linus Walleij

\
 
 \ /
  Last update: 2017-11-29 13:56    [W:0.250 / U:2.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site