lkml.org 
[lkml]   [2017]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.18 29/67] clk: ti: dra7-atl-clock: Fix of_node reference counting
    Date
    3.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Peter Ujfalusi <peter.ujfalusi@ti.com>

    commit 660e1551939931657808d47838a3f443c0e83fd0 upstream.

    of_find_node_by_name() will call of_node_put() on the node so we need to
    get it first to avoid warnings.
    The cfg_node needs to be put after we have finished processing the
    properties.

    Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
    Tested-by: Nishanth Menon <nm@ti.com>
    Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/clk/ti/clk-dra7-atl.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/clk/ti/clk-dra7-atl.c
    +++ b/drivers/clk/ti/clk-dra7-atl.c
    @@ -259,6 +259,7 @@ static int of_dra7_atl_clk_probe(struct

    /* Get configuration for the ATL instances */
    snprintf(prop, sizeof(prop), "atl%u", i);
    + of_node_get(node);
    cfg_node = of_find_node_by_name(node, prop);
    if (cfg_node) {
    ret = of_property_read_u32(cfg_node, "bws",
    @@ -272,6 +273,7 @@ static int of_dra7_atl_clk_probe(struct
    atl_write(cinfo, DRA7_ATL_AWSMUX_REG(i),
    cdesc->aws);
    }
    + of_node_put(cfg_node);
    }

    cdesc->probed = true;

    \
     
     \ /
      Last update: 2017-11-28 13:39    [W:4.356 / U:0.312 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site