lkml.org 
[lkml]   [2017]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 93/96] btrfs: return the actual error value from from btrfs_uuid_tree_iterate
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Pan Bian <bianpan2016@163.com>


    [ Upstream commit 73ba39ab9307340dc98ec3622891314bbc09cc2e ]

    In function btrfs_uuid_tree_iterate(), errno is assigned to variable ret
    on errors. However, it directly returns 0. It may be better to return
    ret. This patch also removes the warning, because the caller already
    prints a warning.

    Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188731
    Signed-off-by: Pan Bian <bianpan2016@163.com>
    Reviewed-by: Omar Sandoval <osandov@fb.com>
    [ edited subject ]
    Signed-off-by: David Sterba <dsterba@suse.com>

    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/btrfs/uuid-tree.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    --- a/fs/btrfs/uuid-tree.c
    +++ b/fs/btrfs/uuid-tree.c
    @@ -348,7 +348,5 @@ skip:

    out:
    btrfs_free_path(path);
    - if (ret)
    - btrfs_warn(fs_info, "btrfs_uuid_tree_iterate failed %d", ret);
    - return 0;
    + return ret;
    }

    \
     
     \ /
      Last update: 2017-11-28 13:11    [W:4.075 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site