Messages in this thread | | | From | Gimcuan Hui <> | Date | Tue, 28 Nov 2017 11:25:50 +0000 | Subject | Re: [PATCH] USB: serial: Clean up the return values of read_reg and write_reg |
| |
On 28 November 2017 at 08:47, Johan Hovold <johan@kernel.org> wrote: > On Mon, Nov 27, 2017 at 03:36:51PM +0000, Gimcuan Hui wrote: >> write_reg returns 0 on success, we can make it more explicit by returning >> number 0 instead of result variable. >> >> read_reg should return 0 on success since this is a more common pattern. >> >> The user of read_reg has been clean-up and should be at the same commit. >> >> Signed-off-by: Gimcuan Hui <gimcuan@gmail.com> > > Thanks for the update. Now applied for -next with a slightly modified > summary: > > USB: serial: ark3116: clean up return values of register accessors > > Johan
:)
gimcuan
| |