Messages in this thread | | | Subject | Re: [PATCH] tipc: call tipc_rcv() only if bearer is up in tipc_udp_recv() | From | Tommi Rantala <> | Date | Tue, 28 Nov 2017 20:16:20 +0200 |
| |
On 28.11.2017 16:58, David Miller wrote: > From: Tommi Rantala <tommi.t.rantala@nokia.com> > Date: Tue, 28 Nov 2017 14:53:15 +0200 > >> - >> - if (unlikely(msg_user(hdr) == LINK_CONFIG)) { >> - err = tipc_udp_rcast_disc(b, skb); >> - if (err) >> - goto rcu_out; >> + } else { >> + if (unlikely(b && msg_user(hdr) == LINK_CONFIG)) >> + tipc_udp_rcast_disc(b, skb); >> + kfree_skb(skb); >> } > > Either put the 'err' propagation back or clearly explain in your > commit log message why this part of the change if absolutely essential > for this bug fix. > > Thank you. >
Thanks for the feedback. I'll post patch v2 soon.
-Tommi
| |