Messages in this thread | | | Date | Tue, 28 Nov 2017 16:13:08 +0100 (CET) | From | Thomas Voegtle <> | Subject | Re: [PATCH] drm/fb_helper: Disable all crtc's when initial setup fails. |
| |
On Tue, 28 Nov 2017, Daniel Vetter wrote:
> On Tue, Nov 28, 2017 at 12:16:03PM +0100, Maarten Lankhorst wrote: >> Some drivers like i915 start with crtc's enabled, but with deferred >> fbcon setup they were no longer disabled as part of fbdev setup. >> Headless units could no longer enter pc3 state because the crtc was >> still enabled. >> >> Fix this by calling restore_fbdev_mode when we would have called >> it otherwise once during initial fbdev setup. >> >> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> >> Fixes: ca91a2758fce ("drm/fb-helper: Support deferred setup") > > Please use dim fixes to get a more complete Cc: list for regression fixes. > >> Cc: <stable@vger.kernel.org> # v4.14+ >> Reported-by: Thomas Voegtle <tv@lio96.de> > > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> > > But please confirm with the reporter that it indeed fixes the issue before > pushing. > -Daniel
I re-checked the latest version of the patch and it indeed fixes the problem.
Thanks,
Thomas
| |