Messages in this thread | | | Date | Mon, 27 Nov 2017 15:38:52 +0200 | From | Heikki Krogerus <> | Subject | Re: [RFC PATCH v2 6/7] typec: tcpm: Represent source supply through power_supply class |
| |
On Sat, Nov 25, 2017 at 03:03:02PM +0100, Hans de Goede wrote: > > Is it OK to everybody that the type of the psy is changed like that? > > Hans?! > > > > We do have drivers that already change the type, for example > > drivers/power/supply/isp1704_charger.c, but what does the user space > > expect? The ABI for the power supply class was never documented I > > guess. > > The main userspace consumer of the power_supply sysfs class is upower, > upower knows about 3 types: "Mains", "Battery" and "USB", anything > else it gives a type of UP_DEVICE_KIND_UNKNOWN. So POWER_SUPPLY_TYPE_USB_TYPE_C > vs POWER_SUPPLY_TYPE_USB_PD_PPS does matter to it.
OK.
Thanks Hans,
-- heikki
| |