Messages in this thread | | | From | Logan Gunthorpe <> | Date | Sun, 26 Nov 2017 23:40:16 -0700 | Subject | Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line |
| |
On 26/11/17 11:34 PM, Julia Lawall wrote: > It would probably be better not to mention the KERN_CONT possibility at > all.
Oh? I don't disagree... but what are we supposed to do in these cases? The way v2 of my patch works it just says that there is a missing new line. But Joe calls that a false positive. So if we can't report that it's missing a new line and we can't say it looks like it needs a KERN_CONT, then what can we do? The case is obviously wrong in some way or another so we probably shouldn't just ignore it.
Logan
| |