Messages in this thread | | | Subject | Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line | From | Joe Perches <> | Date | Sun, 26 Nov 2017 14:29:42 -0800 |
| |
On Sun, 2017-11-26 at 10:38 -0700, Logan Gunthorpe wrote: > > On 25/11/17 11:01 PM, Joe Perches wrote: > > It doesn't really work. > > That's rather hyperbolic and I don't appreciate the tone.
What I wrote is neither hyperbolic nor tonal.
I'm rather familiar with checkpatch.
High false positive messages are avoided by checkpatch and new tests with high false positive rates are not accepted.
This proposal has a very high false positive rate.
So, as written. nack.
Keep at it though. Maybe something useful will be produced with more effort.
cheers, Joe
| |