Messages in this thread | | | Date | Fri, 24 Nov 2017 12:37:50 -0800 | From | Eric Biggers <> | Subject | Re: [PATCH] KEYS: remove unnecessary get/put of explicit dest_keyring |
| |
On Fri, Nov 24, 2017 at 03:52:05PM +0000, David Howells wrote: > Eric Biggers <ebiggers3@gmail.com> wrote: > > > - construct_get_dest_keyring(&dest_keyring); > > This will break. construct_get_dest_keyring() does other things than just > getting a ref on whatever dest_keyring points to. >
Not if dest_keyring is non-NULL (i.e. explicitly specified), which it is in this case.
Eric
| |