This message generated a parse failure. Raw output follows here. Please use 'back' to navigate. From devnull@lkml.org Sat Apr 27 05:47:22 2024 >From mailfetcher Fri Nov 24 12:33:11 2017 Envelope-to: lkml@grols.ch Delivery-date: Fri, 24 Nov 2017 12:33:10 +0100 Received: from srv.grols.ch [5.172.41.101] by 0359fc81c977 with IMAP (fetchmail-6.3.26) for (single-drop); Fri, 24 Nov 2017 12:33:11 +0100 (CET) Received: from vger.kernel.org ([209.132.180.67]) by home.grols.ch with esmtp (Exim 4.89) (envelope-from ) id 1eICEI-0006J4-7N for lkml@grols.ch; Fri, 24 Nov 2017 12:33:10 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753416AbdKXLdH (ORCPT ); Fri, 24 Nov 2017 06:33:07 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:58446 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753239AbdKXLdH (ORCPT ); X-Ironport-AV: E=Sophos;i="5.44,447,1505772000"; d="scan'208";a="245882017" Received: from vaio-julia.rsr.lip6.fr ([132.227.76.33]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Nov 2017 12:33:05 +0100 Date: Fri, 24 Nov 2017 12:33:04 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Adam Thomson Cc: SF Markus Elfring , "alsa-devel@alsa-project.org" , Support Opensource , Jaroslav Kysela , Liam Girdwood Message-Id: References: <6dc71b14-4c14-82f6-9dad-92bfa9854de2@users.sourceforge.net> <2E89032DDAA8B9408CB92943514A0337014C1B116F@SW-EX-MBX01.diasemi.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Mime-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-640844049-1511523185=:3316" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-Id: X-Mailing-List: linux-kernel@vger.kernel.org Received-SPF: none client-ip=209.132.180.67; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org X-Spam-Score: 2.2 X-Spam-Score-Bar: ++ X-Spam-Action: no action X-Spam-Report: Action: no action Symbol: R_SPF_NA(0.00) Symbol: MIME_GOOD(-0.10) Symbol: CTYPE_MIXED_BOGUS(1.00) Symbol: MAILLIST(-0.20) Symbol: ASN(0.00) Symbol: RCVD_COUNT_THREE(0.00) Symbol: TO_DN_SOME(0.00) Symbol: MID_RHS_NOT_FQDN(0.50) Symbol: FROM_HAS_DN(0.00) S --8323329-640844049-1511523185=:3316 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Fri, 24 Nov 2017, Adam Thomson wrote: > On 23 November 2017 17:33, SF Markus Elfring wrote: > > > From: Markus Elfring > > Date: Thu, 23 Nov 2017 17:56:54 +0100 > > > > Omit an extra message for a memory allocation failure in this function. > > I'm not sure this is an extra message. We don't return -ENOMEM as a result of > this operation and probe won't fail on this. So does devm_kzalloc() print error > messages? Unless there is NO WARN, a backtrace will be generated in the out of memory case. julia > > > This issue was detected by using the Coccinelle software. > > > > Signed-off-by: Markus Elfring > > --- > > sound/soc/codecs/da7213.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/sound/soc/codecs/da7213.c b/sound/soc/codecs/da7213.c > > index 41d9b1da27c2..d1b77a0e3b74 100644 > > --- a/sound/soc/codecs/da7213.c > > +++ b/sound/soc/codecs/da7213.c > > @@ -1654,10 +1654,8 @@ static struct da7213_platform_data > > u32 fw_val32; > > > > pdata = devm_kzalloc(codec->dev, sizeof(*pdata), GFP_KERNEL); > > - if (!pdata) { > > - dev_warn(codec->dev, "Failed to allocate memory for pdata\n"); > > + if (!pdata) > > return NULL; > > - } > > > > if (device_property_read_u32(dev, "dlg,micbias1-lvl", &fw_val32) >= 0) > > pdata->micbias1_lvl = da7213_of_micbias_lvl(codec, fw_val32); > > -- > > 2.15.0 > N?????r??y??????X??ǧv???)޺{.n?????z?ޖ6?????)?????*jg????????ݢj/???z?ޖ????ޙ????&?)ߡ?a???????G???????:+v???w???? --8323329-640844049-1511523185=:3316--