Messages in this thread Patch in this message | | | Date | Thu, 23 Nov 2017 11:09:59 -0800 | From | tip-bot for Colin Ian King <> | Subject | [tip:irq/urgent] irqchip/qcom: Fix u32 comparison with value less than zero |
| |
Commit-ID: e9990d70e8a063a7b894c5cbb99f630a0f41200d Gitweb: https://git.kernel.org/tip/e9990d70e8a063a7b894c5cbb99f630a0f41200d Author: Colin Ian King <colin.king@canonical.com> AuthorDate: Fri, 17 Nov 2017 18:35:53 +0000 Committer: Thomas Gleixner <tglx@linutronix.de> CommitDate: Thu, 23 Nov 2017 20:03:58 +0100
irqchip/qcom: Fix u32 comparison with value less than zero
The comparison of u32 nregs being less than zero is never true since nregs is unsigned. Fix this by making nregs a signed integer.
Fixes: f20cc9b00c7b ("irqchip/qcom: Add IRQ combiner driver") Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Marc Zyngier <marc.zyngier@arm.com> Cc: kernel-janitors@vger.kernel.org Cc: Jason Cooper <jason@lakedaemon.net> Link: https://lkml.kernel.org/r/20171117183553.2739-1-colin.king@canonical.com
--- drivers/irqchip/qcom-irq-combiner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/qcom-irq-combiner.c b/drivers/irqchip/qcom-irq-combiner.c index 6aa3ea4..f312659 100644 --- a/drivers/irqchip/qcom-irq-combiner.c +++ b/drivers/irqchip/qcom-irq-combiner.c @@ -238,7 +238,7 @@ static int __init combiner_probe(struct platform_device *pdev) { struct combiner *combiner; size_t alloc_sz; - u32 nregs; + int nregs; int err; nregs = count_registers(pdev);
| |