Messages in this thread | | | Date | Thu, 23 Nov 2017 17:35:06 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH] kaslr: clean up a useless variable and some usless space |
| |
On Thu, 23 Nov 2017, Thomas Gleixner wrote:
> On Thu, 23 Nov 2017, Chao Fan wrote: > > > There are two same variable "rc" in mem_avoid_memmap. One is in the > > circulation, the other is out of the circulation. The one out will never > > be used, so drop it. > > > > Signed-off-by: Chao Fan <fanc.fnst@cn.fujitsu.com> > > --- > > arch/x86/boot/compressed/kaslr.c | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/arch/x86/boot/compressed/kaslr.c b/arch/x86/boot/compressed/kaslr.c > > index a63fbc25ce84..8199a6187251 100644 > > --- a/arch/x86/boot/compressed/kaslr.c > > +++ b/arch/x86/boot/compressed/kaslr.c > > @@ -171,7 +171,6 @@ parse_memmap(char *p, unsigned long long *start, unsigned long long *size) > > static void mem_avoid_memmap(char *str) > > { > > static int i; > > - int rc; > > > > if (i >= MAX_MEMMAP_REGIONS) > > return; > > @@ -219,7 +218,7 @@ static int handle_mem_memmap(void) > > return 0; > > > > tmp_cmdline = malloc(len + 1); > > - if (!tmp_cmdline ) > > + if (!tmp_cmdline) > > error("Failed to allocate space for tmp_cmdline"); > > This change is unrelated.
Never mind. Just noticed that it's mentioned in $subject.
| |