| From | Linus Walleij <> | Date | Thu, 23 Nov 2017 10:56:19 +0100 | Subject | Re: [PATCH V14 02/24] mmc: block: Check return value of blk_get_request() |
| |
On Tue, Nov 21, 2017 at 2:42 PM, Adrian Hunter <adrian.hunter@intel.com> wrote:
> blk_get_request() can fail, always check the return value. > > Fixes: 0493f6fe5bde ("mmc: block: Move boot partition locking into a driver op") > Fixes: 3ecd8cf23f88 ("mmc: block: move multi-ioctl() to use block layer") > Fixes: 614f0388f580 ("mmc: block: move single ioctl() commands to block requests") > Fixes: 627c3ccfb46a ("mmc: debugfs: Move block debugfs into block module") > Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org> This should also go into fixes I think.
I guess this particular sloppiness was due to modeling the code on drivers/ide/* which doesn't check the return value either.
I should go and fix that :/
Yours, Linus Walleij
|