lkml.org 
[lkml]   [2017]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 077/133] ftrace: Fix selftest goto location on error
    3.16.51-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>

    commit 46320a6acc4fb58f04bcf78c4c942cc43b20f986 upstream.

    In the second iteration of trace_selftest_ops(), the error goto label is
    wrong in the case where trace_selftest_test_global_cnt is off. In the
    case of error, it leaks the dynamic ops that was allocated.

    Fixes: 95950c2e ("ftrace: Add self-tests for multiple function trace users")
    Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    kernel/trace/trace_selftest.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/kernel/trace/trace_selftest.c
    +++ b/kernel/trace/trace_selftest.c
    @@ -272,7 +272,7 @@ static int trace_selftest_ops(struct tra
    goto out_free;
    if (cnt > 1) {
    if (trace_selftest_test_global_cnt == 0)
    - goto out;
    + goto out_free;
    }
    if (trace_selftest_test_dyn_cnt == 0)
    goto out_free;
    \
     
     \ /
      Last update: 2017-11-22 03:32    [W:4.103 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site