lkml.org 
[lkml]   [2017]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] HID: cp2112: Fix I2C_BLOCK_DATA transactions
On Tue, Nov 21, 2017 at 05:45:32PM +0100, Jiri Kosina wrote:
> On Tue, 21 Nov 2017, Jiri Kosina wrote:
>
> > > The existing driver erroneously treats I2C_BLOCK_DATA and BLOCK_DATA
> > > commands the same. Fix the logic for I2C_BLOCK_DATA reads and writes.
> >
> > Addin David, the original author of the driver (and the code in question
> > as well) to CC.
>
> Alright, that address bounces.
>
> In that case -- could you please be a little bit more specific in the
> changelog? Namely: what are the observable effects of this bug (did you
> find it by code inspection or have you seen it triggering) and why this is
> a proper fix for that bug.

Thanks for the feedback Jiri, I will send out a new patch shortly with more detail in the changelog.

\
 
 \ /
  Last update: 2017-11-21 19:40    [W:0.057 / U:1.580 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site