lkml.org 
[lkml]   [2017]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [RFC] [PATCH] drm: adv7511/33: Fix adv7511_cec_init() failure handling
    On Fri, Nov 17, 2017 at 12:43 AM, Hans Verkuil <hverkuil@xs4all.nl> wrote:
    > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
    > index 3a33075dbb22..56eeeea6a1fa 100644
    > --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
    > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
    > @@ -1202,9 +1202,7 @@ static int adv7511_probe(struct i2c_client *i2c, const struct i2c_device_id *id)
    > offset = adv7511->type == ADV7533 ? ADV7533_REG_CEC_OFFSET : 0;
    >
    > #ifdef CONFIG_DRM_I2C_ADV7511_CEC
    > - ret = adv7511_cec_init(dev, adv7511, offset);
    > - if (ret)
    > - goto err_unregister_cec;
    > + adv7511_cec_init(dev, adv7511, offset);
    > #else
    > regmap_write(adv7511->regmap, ADV7511_REG_CEC_CTRL + offset,
    > ADV7511_CEC_CTRL_POWER_DOWN);


    One tiny nit-pick I realized I should have made in my patch...

    In the !CONFIG_DRM_I2C_ADV7511_CEC, can you just define adv7511_cec_init() as
    {
    regmap_write(adv7511->regmap, ADV7511_REG_CEC_CTRL + offset,
    ADV7511_CEC_CTRL_POWER_DOWN);
    }

    Then we can call it either way, and don't need to have the ufly
    #ifdefs in the adv7511_probe function?

    thanks
    -john

    \
     
     \ /
      Last update: 2017-11-20 21:14    [W:4.051 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site