Messages in this thread | | | Date | Thu, 2 Nov 2017 11:48:25 -0700 | From | Alexei Starovoitov <> | Subject | Re: [PATCH 1/2] [net-next] bpf: fix link error without CONFIG_NET |
| |
On Thu, Nov 02, 2017 at 10:55:30AM -0700, Jakub Kicinski wrote: > On Thu, 2 Nov 2017 12:05:51 +0100, Arnd Bergmann wrote: > > I ran into this link error with the latest net-next plus linux-next > > trees when networking is disabled: > > > > kernel/bpf/verifier.o:(.rodata+0x2958): undefined reference to `tc_cls_act_analyzer_ops' > > kernel/bpf/verifier.o:(.rodata+0x2970): undefined reference to `xdp_analyzer_ops' > > > > It seems that the code was written to deal with varying contents of > > the arrray, but the actual #ifdef was missing. Both tc_cls_act_analyzer_ops > > and xdp_analyzer_ops are defined in the core networking code, so adding > > a check for CONFIG_NET seems appropriate here, and I've verified this with > > many randconfig builds > > > > Fixes: 4f9218aaf8a4 ("bpf: move knowledge about post-translation offsets out of verifier") > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Thanks Arnd! I was hoping to nuke this code before build bots catch up > to me, didn't work out :)
yeah. Jakub's patches may not make it in time for net-next closing. so let's use this fix for now.
Acked-by: Alexei Starovoitov <ast@kernel.org>
| |