lkml.org 
[lkml]   [2017]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 3.10 112/139] mm: fix overflow check in expand_upwards()
On Wed, Nov 1, 2017 at 10:26 PM, Willy Tarreau <w@1wt.eu> wrote:
> From: Helge Deller <deller@gmx.de>
>
> commit 37511fb5c91db93d8bd6e3f52f86e5a7ff7cfcdf upstream.
>
> Jörn Engel noticed that the expand_upwards() function might not return

Jörn (yeah, the original commit suffers from this, too ;-)

> -ENOMEM in case the requested address is (unsigned long)-PAGE_SIZE and
> if the architecture didn't defined TASK_SIZE as multiple of PAGE_SIZE.
>
> Affected architectures are arm, frv, m68k, blackfin, h8300 and xtensa
> which all define TASK_SIZE as 0xffffffff, but since none of those have
> an upwards-growing stack we currently have no actual issue.
>
> Nevertheless let's fix this just in case any of the architectures with
> an upward-growing stack (currently parisc, metag and partly ia64) define
> TASK_SIZE similar.
>
> Link: http://lkml.kernel.org/r/20170702192452.GA11868@p100.box
> Fixes: bd726c90b6b8 ("Allow stack to grow up to address space limit")
> Signed-off-by: Helge Deller <deller@gmx.de>
> Reported-by: Jörn Engel <joern@purestorage.com>
> Cc: Hugh Dickins <hughd@google.com>
> Cc: Oleg Nesterov <oleg@redhat.com>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Willy Tarreau <w@1wt.eu>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

\
 
 \ /
  Last update: 2017-11-02 10:21    [W:0.893 / U:0.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site