Messages in this thread | | | From | Dan Williams <> | Date | Sun, 19 Nov 2017 20:34:58 -0800 | Subject | Re: linux-next: build failure after merge of the akpm-current tree |
| |
On Sun, Nov 19, 2017 at 8:32 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote: > Hi Dan, > > On Sun, 19 Nov 2017 20:25:18 -0800 Dan Williams <dan.j.williams@intel.com> wrote: >> >> Ugh, yes. Looks correct. I might have confused my build success >> notifications from 0day. I'll spin out a new branch to make sure this >> is the last of it. > > Thanks. > > While I have your attention ... did you consider using the other > paradigm: > > In arch include files: > #define pud_write pud_write > static inline int pud_write(pud_t pud) > ..... > > Then in include/asm-generic/pgtable.h: > > #ifndef pud_write > tatic inline int pud_write(pud_t pud) > { > .... > } > #endif > > If you had, then the powerpc code would have worked ... ;-) > and many of the other interfaces in include/asm-generic/pgtable.h are > protected that way ...
I like that better. I simply cargo-culted the way pmd_write() was defined, and should have given it a bit more thought. Andrew, I'll respin these with Stephen's suggestion.
| |