lkml.org 
[lkml]   [2017]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/5 v2] ASoC: nuc900: Fix platform_get_irq's error checking
    On Sat, Nov 18, 2017 at 10:57:53AM +0530, Arvind Yadav wrote:
    > The platform_get_irq() function returns negative if an error occurs.
    > zero or positive number on success. platform_get_irq() error checking
    > for zero is not correct.

    IRQ 0 is not a valid interrupt. The correct test here is <= 0.
    Please rework your patches for this.

    Thanks.

    --
    RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
    FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
    According to speedtest.net: 8.21Mbps down 510kbps up

    \
     
     \ /
      Last update: 2017-11-18 09:20    [W:4.061 / U:0.980 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site