Messages in this thread Patch in this message | | | From | Arvind Yadav <> | Subject | [PATCH 02/10 v3] Input: omap4-keypad: Fix platform_get_irq's error checking | Date | Sat, 18 Nov 2017 16:25:09 +0530 |
| |
The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- changes in v2: Return irq insted of -EINVAL. changes in v3 : Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
drivers/input/keyboard/omap4-keypad.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard/omap4-keypad.c index 940d38b..9ad840c 100644 --- a/drivers/input/keyboard/omap4-keypad.c +++ b/drivers/input/keyboard/omap4-keypad.c @@ -251,9 +251,9 @@ static int omap4_keypad_probe(struct platform_device *pdev) } irq = platform_get_irq(pdev, 0); - if (!irq) { + if (irq <= 0) { dev_err(&pdev->dev, "no keyboard irq assigned\n"); - return -EINVAL; + return irq; } keypad_data = kzalloc(sizeof(struct omap4_keypad), GFP_KERNEL); -- 2.7.4
| |