lkml.org 
[lkml]   [2017]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 74/83] perf callchain: Reset cursor arg instead of callchain_cursor
    Date
    From: Jiri Olsa <jolsa@kernel.org>

    We already pass cursor into thread__resolve_callchain function, so
    there's no point in resetting the global instance.

    Signed-off-by: Jiri Olsa <jolsa@kernel.org>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Wang Nan <wangnan0@huawei.com>
    Link: http://lkml.kernel.org/n/tip-puk015qvuppao9m1xtdy9v7j@git.kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/util/machine.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
    index 270f3223c6df..64d255f6a537 100644
    --- a/tools/perf/util/machine.c
    +++ b/tools/perf/util/machine.c
    @@ -2204,7 +2204,7 @@ int thread__resolve_callchain(struct thread *thread,
    {
    int ret = 0;

    - callchain_cursor_reset(&callchain_cursor);
    + callchain_cursor_reset(cursor);

    if (callchain_param.order == ORDER_CALLEE) {
    ret = thread__resolve_callchain_sample(thread, cursor,
    --
    2.13.6
    \
     
     \ /
      Last update: 2017-11-17 21:21    [W:4.062 / U:0.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site