lkml.org 
[lkml]   [2017]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 02/13] x86/paravirt: Fix output constraint macro names
    From
    Date
    On 16/11/17 21:50, Josh Poimboeuf wrote:
    > On Wed, Oct 25, 2017 at 11:33:43AM +0200, Juergen Gross wrote:
    >> On 04/10/17 17:58, Josh Poimboeuf wrote:
    >>> Some of the paravirt '*_CLOBBERS' macros refer to output constraints
    >>> instead of clobbers, which makes the code extra confusing. Rename the
    >>> output constraint related macros to '*_OUTPUTS'.
    >>>
    >>> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
    >>
    >> I'm fine with the changes, but you might want to rename the "call_clbr"
    >> parameter of ____PVOP_[V]CALL, too, e.g. to "outputs".
    >
    > Yeah, good catch.
    >
    >> You could then drop the "CALL_" from the macros, too.
    >
    > Hm, which macros are you referring to, and why?

    Good question. I think I didn't take the *CALLEE* macros into account.
    So please ignore this remark.


    Juergen

    \
     
     \ /
      Last update: 2017-11-17 17:18    [W:2.910 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site