Messages in this thread | | | Date | Fri, 17 Nov 2017 13:35:17 +0100 | From | Sebastian Reichel <> | Subject | Re: [PATCH v2] phy: cpcap-usb: Fix platform_get_irq_byname's error checking. |
| |
Hi,
On Fri, Nov 17, 2017 at 04:55:35PM +0530, Arvind Yadav wrote: > The platform_get_irq_byname() function returns negative if an error occurs. > zero or positive number on success. platform_get_irq_byname() error > checking for zero is not correct. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > ---
Fixes: 6d6ce40f63af ("phy: cpcap-usb: Add CPCAP PMIC USB support") Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
-- Sebastian
> changes in v1 : > Patch description was not correct. > > drivers/phy/motorola/phy-cpcap-usb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/motorola/phy-cpcap-usb.c b/drivers/phy/motorola/phy-cpcap-usb.c > index accaaac..6601ad0 100644 > --- a/drivers/phy/motorola/phy-cpcap-usb.c > +++ b/drivers/phy/motorola/phy-cpcap-usb.c > @@ -310,7 +310,7 @@ static int cpcap_usb_init_irq(struct platform_device *pdev, > int irq, error; > > irq = platform_get_irq_byname(pdev, name); > - if (!irq) > + if (irq < 0) > return -ENODEV; > > error = devm_request_threaded_irq(ddata->dev, irq, NULL, > -- > 2.7.4 > [unhandled content-type:application/pgp-signature] | |