Messages in this thread | | | From | Arnd Bergmann <> | Date | Thu, 16 Nov 2017 12:35:12 +0100 | Subject | Re: [PATCH] net/smc: Fix preinitialization of buf_desc in __smc_buf_create() |
| |
On Thu, Nov 16, 2017 at 12:22 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > With gcc-4.1.2: > > net/smc/smc_core.c: In function ‘__smc_buf_create’: > net/smc/smc_core.c:567: warning: ‘bufsize’ may be used uninitialized in this function > > Indeed, if the for-loop is never executed, bufsize is used > uninitialized. In addition, buf_desc is stored for later use, while it > is still a NULL pointer. > > Before, error handling was done by checking if buf_desc is non-NULL. > The cleanup changed this to an error check, but forgot to update the > preinitialization of buf_desc to an error pointer. > > Update the preinitializatin of buf_desc to fix this. > > Fixes: b33982c3a6838d13 ("net/smc: cleanup function __smc_buf_create()") > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- > I don't know if this can ever happen, but the old code handled it.
Acked-by: Arnd Bergmann <arnd@arndb.de>
This one I could reproduce with gcc-4.1 on x86, but not gcc-4.2 or higher.
| |