lkml.org 
[lkml]   [2017]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] memory hotplug: fix comments when add section
On Wed 15-11-17 16:40:05, Fan Du wrote:
> Here, pfn_to_node should be page_to_nid.
>
> Signed-off-by: Fan Du <fan.du@intel.com>

Yes, it is a typo. And the one worth fixing because this will make git grep
great again

Acked-by: Michal Hocko <mhocko@suse.com>

> ---
> mm/memory_hotplug.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index d4b5f29..c3c1c57 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -265,7 +265,7 @@ static int __meminit __add_section(int nid, unsigned long phys_start_pfn,
> /*
> * Make all the pages reserved so that nobody will stumble over half
> * initialized state.
> - * FIXME: We also have to associate it with a node because pfn_to_node
> + * FIXME: We also have to associate it with a node because page_to_nid
> * relies on having page with the proper node.
> */
> for (i = 0; i < PAGES_PER_SECTION; i++) {
> --
> 1.8.3.1

--
Michal Hocko
SUSE Labs

\
 
 \ /
  Last update: 2017-11-15 10:20    [W:0.025 / U:0.732 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site