lkml.org 
[lkml]   [2017]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RESEND PATCH v2 3/4] x86/umip: Identify the str and sldt instructions
On Tue, Nov 14, 2017 at 08:21:57AM +0100, Ingo Molnar wrote:
>
> * Ricardo Neri <ricardo.neri-calderon@linux.intel.com> wrote:
>
> > The instructions STR and SLDT are not emulated in any case. Thus, it made
> > sense to not implement functionality to identify them. However, a
> > subsequent commit will introduce functionality to warn about the use of
> > all the instructions that UMIP protect, not only those that are emulated.
> > A first step for that is the ability to identify them.
> >
> > Plus, now that STR and SLDT are identified, we need to explicitly avoid
> > their emulation (i.e., not rely on unsuccessful identification). Group
> > togehter all the cases that we do not want to emulate: STR, SLDT and user
> > long mode processes.
> >
> > Cc: Andy Lutomirski <luto@kernel.org>
> > Cc: H. Peter Anvin <hpa@zytor.com>
> > Cc: Borislav Petkov <bp@suse.de>
> > Cc: Tony Luck <tony.luck@intel.com>
> > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > Cc: Ravi V. Shankar <ravi.v.shankar@intel.com>
> > Cc: x86@kernel.org
> > Signed-off-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
>
> Sigh, the _title_ still refers to 'str'...
>
> I'll fix it up, no need to resend, but this lack of attention to details is
> seriously sad.

I apologize for the oversight. I focused on the code and changelog. Thanks for
fixing it!

Thanks and BR,
Ricardo

\
 
 \ /
  Last update: 2017-11-15 03:45    [W:0.053 / U:2.144 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site