lkml.org 
[lkml]   [2017]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] x86: use cpufreq_quick_get() for /proc/cpuinfo "cpu MHz" again
Date
On Wednesday, November 15, 2017 12:53:24 AM CET Thomas Gleixner wrote:
> On Tue, 14 Nov 2017, Linus Torvalds wrote:
>
> > On Tue, Nov 14, 2017 at 2:47 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> > >
> > > So what about the one below? It works for me as expected.
> >
> > Can somebody with 100+ cores test this? Ingo? You had a 160 core
> > machine that took forever, didn't you..
>
> On a 144 CPUs machine:
>
> time cat /proc/cpuinfo >/dev/null
>
> Current head:
>
> real 0m0.003s
> user 0m0.000s
> sys 0m0.002s
>
> Current head + Raphaels patch:
>
> real 0m0.029s
> user 0m0.000s
> sys 0m0.010s
>
> So that patch is actually slower.

Thanks for testing!

It is adding a delay (mostly because it has to allow APERF and MPERF to grow
somewhat for the frequency computation to produce a useful result), so it will
be slower even in theory, but really the question is whether or not the slow
down is acceptable.

It doesn't look horrible to me, but that's my patch after all. :-)

\
 
 \ /
  Last update: 2017-11-15 01:07    [W:0.074 / U:9.240 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site