lkml.org 
[lkml]   [2017]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] lib: test module for find_*_bit() functions
On Tue, 14 Nov 2017 13:07:30 +0300 Yury Norov <ynorov@caviumnetworks.com> wrote:

> > Yyra, you can grab CONFIG_BENCHMARK_* namespace :-)
>
> There's no CONFIG_BENCHMARK_* namespace actually.

Alexey means you can be the first user of CONFIG_BENCHMARK_*.

> The 'CONFIG_*_BENCHMARK' is
> referenced only 3 times in linux sources - CONFIG_RING_BUFFER_BENCHMARK,
> CONFIG_TRACEPOINT_BENCHMARK and CONFIG_GUP_BENCHMARK, so I simply didn't know
> about it. Some other tests like lib/rbtree_test.c also measure performance and
> use TEST namespace, but if you think it's better, I don't object to change it.
>
> > Another thing:
> >
> > > +
> > > + return 0;
> > > +}
> > > +module_init(find_bit_test);
> > > +
> > > +static void __exit test_find_bit_cleanup(void)
> > > +{
> > > +}
> > > +module_exit(test_find_bit_cleanup);
> >
> > module exit hook is entirely unnecessary as you can return -E from init hook.
> > See lib/test-kstrtox.c
>
> Ack.
>
> I thought to send v3, but the patch is already in next tree, so I'll
> send fix in separated patch. OK?

Either approach is OK.

\
 
 \ /
  Last update: 2017-11-15 00:57    [W:0.037 / U:3.512 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site