lkml.org 
[lkml]   [2017]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [GIT pull] printk updates for 4.15
On Tue, Nov 14, 2017 at 2:50 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
>
> Something like the untested patch below should do the storage and converts
> the primary timestamp from local_clock() to clock monotonic.

This may work.

> - u64 ts_nsec; /* timestamp in nanoseconds */
> + /* Timestamps in nanoseconds */
> + union {
> + u64 ts_nsec;
> + struct timestamps ts;
> + };

But I'd skip the union, and just search-and-replace the ts_nsec ->
ts.mono. You did that in at least one place anyway.

Because as it is, that's just too subtle and hard to read. Don't make
it worse by having a magical "ts_nsec is also ts.mono, but you have to
look in two different files to see that.

That file is messy enough as-is.

Linus

\
 
 \ /
  Last update: 2017-11-15 00:00    [W:0.074 / U:3.896 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site