lkml.org 
[lkml]   [2017]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v3 2/2] perf/bench/numa: Handle discontiguous/sparse numa nodes
    From
    Date
    Hi Naveen,


    On Tue, 2017-10-31 at 20:46 +0530, Naveen N. Rao wrote:

    > >   }
    > >   BUG_ON(nr_min > nr_max);
    > > -
    > Looks like an un-necessary change there.
    >
    > - Naveen
    >
    I had hit with this compilation error, so had to move the
    initialization above.
    Please advice. Thanks.

      CC       bench/numa.o
    bench/numa.c: In function ‘calc_convergence’:
    bench/numa.c:1035:3: error: ISO C90 forbids mixed declarations and code
    [-Werror=declaration-after-statement]
       int processes = count_node_processes(node);
       ^
    cc1: all warnings being treated as errors
    mv: cannot stat ‘bench/.numa.o.tmp’: No such file or directory
    make[4]: *** [bench/numa.o] Error 1
    make[3]: *** [bench] Error 2
    make[2]: *** [perf-in.o] Error 2
    make[1]: *** [sub-make] Error 2
    make: *** [all] Error 2

    Regards,
    -Satheesh.
    > >
    > >   BUG_ON(sum > g->p.nr_tasks);
    > >
    > >   if (0 && (sum < g->p.nr_tasks))
    @@ -1027,8 +1029,9 @@ static void calc_convergence(double

    \
     
     \ /
      Last update: 2017-11-14 13:49    [W:3.593 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site