lkml.org 
[lkml]   [2017]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] kbuild: comments correction & update on Makefile.host
From
Date
Masahiro-san,

On 11/14/2017 06:31 PM, Masahiro Yamada wrote:
> Hi Cao,
>
> 2017-11-01 10:43 GMT+09:00 Cao jin <caoj.fnst@cn.fujitsu.com>:
>>
>> # C code
>> -# Executables compiled from a single .c file
>> +# C Executables compiled from a single .c file
>
>
> Is anything wrong with the current comment?
>

Nothing wrong here, just make it looks the same style as its peer below.

>> host-csingle := $(foreach m,$(__hostprogs), \
>> $(if $($(m)-objs)$($(m)-cxxobjs),,$(m)))
>>
>> -# C executables linked based on several .o files
>> +# C executables compiled from several .c files, and only .c files
>
> Your comment is even clearer, but
> I think the current comment is also true, at least.
>

Yes, just make it more clearer and looks the same style as its peer above.

> host-cmulti is liked from .o files
> after each was compiled from .c
>
>

>> # output directory for programs/.o files
>> # hostprogs-y := tools/build may have been specified.
>> -# Retrieve also directory of .o files from prog-objs or prog-cxxobjs notation
>> +# Retrieve also directory of .o files from host-cobjs and host-cxxobjs notation
>> host-objdirs := $(dir $(__hostprogs) $(host-cobjs) $(host-cxxobjs))
>>
>> host-objdirs := $(strip $(sort $(filter-out ./,$(host-objdirs))))
>> --
>
> I am removing all host-objdirs stuff.
> I do not need this hunk.
>

I forget your patches, sorry for the noise here.

--
Sincerely,
Cao jin


\
 
 \ /
  Last update: 2017-11-14 12:53    [W:0.044 / U:1.940 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site