lkml.org 
[lkml]   [2017]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] coccinelle: fix parallel build with CHECK=scripts/coccicheck


On Tue, 14 Nov 2017, Masahiro Yamada wrote:

> Hi Julia,
>
>
> 2017-11-14 18:49 GMT+09:00 Julia Lawall <julia.lawall@lip6.fr>:
> >> +
> >> + # If -j option is given to Make, scripts/coccicheck runs in parallel.
> >> + # If coccinelle also runs in parallel, it fails because multiple processes
> >> + # try to get access to the same subdirectory that stores stdout/stderr.
> >> + # No need to parallelize coccinelle in this case - this mode takes only
> >> + # one file input.
> >> + NPROC=1
> >
> > Since I am also changing Coccinelle to avoid the problem, maybe it would
> > be better to just remove the explanation sentence (If coccinelle also runs
> > in parallel,...).
> >
> > julia
>
> OK. Which lines are unneeded?
>
> Is it OK to remove all the comments, then just add "NPROC=1"?

How about keeping "# No need to parallelize coccinelle in this case - this
mode takes only one file input."?

But if you think it is obvious, it would be ok to remove it also. Someone
can always do git blame and read the commit message if they have
questions.

julia

\
 
 \ /
  Last update: 2017-11-14 12:10    [W:0.048 / U:1.760 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site