lkml.org 
[lkml]   [2017]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 00/24] staging: ccree: more cleanup patches
On Tue, Nov 14, 2017 at 11:33:20AM +0200, Gilad Ben-Yossef wrote:
> On Mon, Nov 13, 2017 at 8:33 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > These cleanups look nice. Thanks.
> >
> > I hope you do a mass remove of likely/unlikely in a patch soon.
> > Whenever, I see one of those in a + line I always have to remind myself
> > that you're planning to do it in a later patch.
> >
>
> So, a question about that - there indeed seems to be an inflation of
> likely/unlikely in the ccree driver, but
> what stopped me from removing them was that I found out I don't have a
> clue about when it's a good idea
> to use them and when it isn't (obviously in places where you know the
> probable code flow of course).
>
> Any hints?

They should only be included if benchmarking shows that it makes a
difference. I think they need to be about 100 right predictions to 1
wrong prediction on a fast path. So remove them all and add them back
one at a time.


regards,
dan carpenter

\
 
 \ /
  Last update: 2017-11-14 10:48    [W:0.063 / U:19.368 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site