Messages in this thread | | | From | Linus Torvalds <> | Date | Mon, 13 Nov 2017 11:36:22 -0800 | Subject | Re: [RFC 6/7] x86/asm: Remap the TSS into the cpu entry area |
| |
On Mon, Nov 13, 2017 at 11:22 AM, Dave Hansen <dave.hansen@intel.com> wrote: > > Aha, and here's the place that you need sizeof(tss_struct) to be nice > and page-aligned.
No, it should _not_ be page-aligned. It should fit _within_ a page, but it 'struct tss_struct' now has something else in front of it, then page-aliging that is actually pointless.
I forget what the actual size is, but aligning the hardware TSS struct to 128 bytes might be sufficient. It's not that big.
Of course, we've had issues with "big" alignments before, in that they haven't been reliable because the base isn't reliably aligned (the stack being the worst case, but even standard data sections have had issues). It's partly why we have special page-aligned sections.
Linus
| |