lkml.org 
[lkml]   [2017]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] clocksource/drivers/timer-of: mark timer_of_exit as __init
From
Date


On 13/11/17 14:58, Daniel Lezcano wrote:
> On 13/11/2017 11:11, Sudeep Holla wrote:

[..]

>>
>> Agreed, may be if we add users which is called from init functions, the
>> warning should disappear. Also as tglx suggested, we could rename if it's
>> just used from init function error/exit paths.
>
> The drivers are not compiled as module AFAICT, the function will be
> called in the init error path.
>

Understood, IMO better to rename the functions as cleanup or something
similar. exit made it sound differently and since there were no users,
I assumed it to be used in remove/exit functions. Sorry for the noise.

--
Regards,
Sudeep

\
 
 \ /
  Last update: 2017-11-13 16:11    [W:0.064 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site