Messages in this thread | | | From | alexander.levin@verizon ... | Subject | Re: [PATCH] lockdep: Add missing declaration of 'pr_cont()' | Date | Mon, 13 Nov 2017 15:09:17 +0000 |
| |
On Tue, Nov 07, 2017 at 05:10:07PM +0100, Alexander Sverdlin wrote: >Hello! > >On Tue Nov 7 03:24:20 2017 Mengting Zhang <zhangmengting@huawei.com> wrote: >> An annoying compile warning due to missing declaration is shown below: >> In file included from lockdep.c:27:0: >> ../../../kernel/locking/lockdep.c: In function >> 'print_unlock_imbalance_bug' : ../../../kernel/locking/lockdep.c:3544:2: >> warning: implicit declaration of function 'pr_cont' >> [-Wimplicit-function-declaration] pr_cont(") at:\n"); ^ >> Adding the declaration of 'pr_cont' fixes the problem. >> >> Signed-off-by: Mengting Zhang <zhangmengting@huawei.com> > >Your commit brought my attention to the fact that commit 681fbec881 brought a regression, rendering 20fb654ae fix ineffective. > >But this is not related to your change, which I believe is correct: >Reviewed-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Thanks! Queued up.
--
Thanks, Sasha
| |