lkml.org 
[lkml]   [2017]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 5/5] perf/script: add support for PERF_SAMPLE_SKID_IP
On Wed, Nov 08, 2017 at 11:57:13PM -0800, Stephane Eranian wrote:
> This patch adds a skid_ip field to perf script
> to dump the raw value of the PERF_SAMPLE_SKID_IP
> field in each sample.
>
> $ perf script -F +ip,+skid_ip ......
>
> The field is not enabled by default.
>
> Signed-off-by: Stephane Eranian <eranian@google.com>
> ---
> tools/perf/Documentation/perf-script.txt | 2 +-
> tools/perf/builtin-script.c | 10 ++++++++--
> 2 files changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/Documentation/perf-script.txt b/tools/perf/Documentation/perf-script.txt
> index 2811fcf684cb..96871bd3a576 100644
> --- a/tools/perf/Documentation/perf-script.txt
> +++ b/tools/perf/Documentation/perf-script.txt
> @@ -117,7 +117,7 @@ OPTIONS
> Comma separated list of fields to print. Options are:
> comm, tid, pid, time, cpu, event, trace, ip, sym, dso, addr, symoff,
> srcline, period, iregs, uregs, brstack, brstacksym, flags, bpf-output, brstackinsn,
> - brstackoff, callindent, insn, insnlen, synth, phys_addr.
> + brstackoff, callindent, insn, insnlen, synth, phys_addr, skid_ip.

while we are at it, could we keep it the same as the field name in perf record?
I dont mind using '-' or '_', just please keep it same

other then that it looks ok, for patchset:

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

\
 
 \ /
  Last update: 2017-11-13 12:53    [W:0.046 / U:1.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site