Messages in this thread | | | From | Krzysztof Kozlowski <> | Date | Mon, 13 Nov 2017 12:33:31 +0100 | Subject | Re: [PATCH v2 1/2] ARM: dts: exynos: Switch to dedicated Odroid-XU3 sound card binding |
| |
On Mon, Nov 13, 2017 at 12:30 PM, Sylwester Nawrocki <s.nawrocki@samsung.com> wrote: > On 11/10/2017 06:14 PM, Krzysztof Kozlowski wrote: >> On Fri, Nov 03, 2017 at 05:54:45PM +0100, Sylwester Nawrocki wrote: >>> The new sound card DT binding is used for Odroid XU3 in order >>> to properly support the HDMI audio path. >>> Clocks configuration is changed so the I2S controller is now the bit >>> and the frame clock master with EPLL as the root clock source. >> >> Patch looks good but I do not understand this last sentence. What did >> you want to say? > > Which part is hard to understand exactly? Perhaps this is clearer? > > "Clocks configuration is changed so the I2S controller is now the bit > clock and the frame clock master. The EPLL output clock is now the > audio root clock adjusted to each audio sample rate." > > Previously the CODEC's internal PLL was used for generating the I2S > bit and frame clocks accorrding to each audio sample rate.
Ahhh, makes sense, the previous "is not the bit and..." mislead me. I thought it's a typo, you wanted to use "but" and something is missing. The extended description is I think better, so I'll use it in commit msg when applying.
Best regards, Krzysztof
| |